◐ Shell
clean mode source ↗

bpo-36577: setup.py reports missing OpenSSL again by tiran · Pull Request #12746 · python/cpython

Conversation

bpo-36146 introduced another regression. In case of missing OpenSSL
libraries or headers, setup.py no longer reported _hashlib and _ssl to
be missing.

Signed-off-by: Christian Heimes <christian@python.org>

@tiran

@xdegaye This is another regression. I found while I was verifying your PR. Thanks again!

@vstinner

@tiran: Oh. We found the same bug and I proposed a similar fix :-) PR #12750.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner

@tiran: I closed my PR. Your PR LGTM.

@tiran

@tiran tiran deleted the bpo-36577-setup-ssl branch

April 9, 2019 16:47