◐ Shell
clean mode source ↗

bpo-30131: Cleanup threads in test_logging by vstinner · Pull Request #1275 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:masterfrom

vstinner:logging_thread

Apr 24, 2017

Merged

bpo-30131: Cleanup threads in test_logging#1275

vstinner

merged 1 commit into

python:masterfrom

vstinner:logging_thread

Conversation

@vstinner

Copy link Copy Markdown

Member

  • Use @support.reap_threads on unit tests creating threads
  • Call TestCase.fail() on thread.join(timeout) failure
 
* Use @support.reap_threads on unit tests creating threads
* Call TestCase.fail() on thread.join(timeout) failure

@mention-bot

Copy link Copy Markdown

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vsajip, @tiran and @benjaminp to be potential reviewers.

@vstinner vstinner merged commit 4bcfa3a into python:master

Apr 24, 2017

@vstinner vstinner deleted the logging_thread branch

April 24, 2017 22:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @mention-bot @the-knights-who-say-ni