◐ Shell
clean mode source ↗

gh-111178: fix UBSan failures in `Modules/_ctypes` by picnixz · Pull Request #129071 · python/cpython

Conversation

ZeroIntensity

picnixz

encukou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

encukou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Don't worry about making it any prettier.

@picnixz

@vstinner I plan to merge this one with no commit message and the PR's title as the commit's title.

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM. I didn't test the change.

@picnixz picnixz deleted the fix/ubsan/ctypes-111178 branch

January 21, 2025 10:50

Labels