gh-111178: fix UBSan failures in `Modules/_ssl/cert.c` by picnixz · Pull Request #129088 · python/cpython
Conversation
| Py_RETURN_NOTIMPLEMENTED; | ||
| } | ||
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)other)->cert); | ||
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)rhs)->cert); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)rhs)->cert); | |
| cmp = X509_cmp(self->cert, _PySSLCertificate_CAST(rhs)->cert); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left out fast casts for which the input has already been checked so that if the macro is one day converted to a function with explicit checks, we don't double checks those
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request
…H-129088) fix UBSan failures for `PySSLCertificate`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels
2 participants
