◐ Shell
clean mode source ↗

gh-128563: Move GO_TO_INSTRUCTION and PREDICT to cases generator by Fidget-Spinner · Pull Request #129115 · python/cpython

Fidget-Spinner

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented

Jan 21, 2025

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

stonebig reacted with heart emoji

@markshannon markshannon left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
A couple of small changes needed.
Comment thread

Lib/test/test_generated_cases.py Outdated

@bedevere-app

bedevere-app Bot commented

Jan 21, 2025

Copy link Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@Fidget-Spinner

Copy link Copy Markdown

Member Author

I have made the requested changes; please review again.

@bedevere-app

bedevere-app Bot commented

Jan 21, 2025

Copy link Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from markshannon

January 21, 2025 10:51

@Fidget-Spinner Fidget-Spinner merged commit 86c1a60 into python:main

Jan 22, 2025

@Fidget-Spinner Fidget-Spinner deleted the generate_goto branch

January 22, 2025 01:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fidget-Spinner @markshannon