◐ Shell
clean mode source ↗

gh-91048: Improve example in `asyncio-graph.rst` doc by sobolevn · Pull Request #129224 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented

Jan 23, 2025

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

I propose adding an explicit name, because it is not clear what "Task-1" and "Task-2" are. Now with this explicit name it is more readable.


📚 Documentation preview 📚: https://cpython-previews--129224.org.readthedocs.build/

@bedevere-app bedevere-app Bot added awaiting core review docs

Documentation in the Doc dir

skip news labels

Jan 23, 2025

@picnixz picnixz changed the title Improve example in asyncio-graph.rst doc gh-91048: Improve example in asyncio-graph.rst doc

Jan 23, 2025

@StanFromIreland StanFromIreland left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this will make it clearer for people less familiar with tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

Docs PRs

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn @kumaraditya303 @StanFromIreland @picnixz