◐ Shell
clean mode source ↗

gh-129223: Do not allow the compiler to optimise away symbols for debug sections by pablogsal · Pull Request #129225 · python/cpython

Merged

ambv

merged 4 commits into

Jan 24, 2025

Conversation

pablogsal

@@ -414,7 +414,11 @@ get_py_runtime(pid_t pid)
static uintptr_t
get_async_debug(pid_t pid)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to avoid returning NULL without an error set as things under search_map_for_section may return without setting an error.

picnixz

@bedevere-bot

@bedevere-bot

@ambv

!buildbot aarch64 Fedora Stable Clang

@bedevere-bot

@ambv

@ambv ambv mentioned this pull request

Jan 24, 2025

@ambv

!buildbot PPC64LE .* Refleaks PR

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @ambv for commit 596a58f 🤖

The command will test the builders whose names match following regular expression: PPC64LE .* Refleaks PR

The builders matched are:

  • PPC64LE Fedora Rawhide Refleaks PR
  • PPC64LE CentOS9 Refleaks PR
  • PPC64LE Fedora Stable Refleaks PR
  • PPC64LE RHEL8 Refleaks PR
  • PPC64LE Fedora Rawhide NoGIL refleaks PR

@ambv

It's weird that Windows 11 and PPC64LE refleaks buildbots are consistently failing with failures that don't look related to external inspection infrastructure:

8 tests failed:
    test_capi test_embed test_import test_interpreters test_json
    test_logging test_sysconfig test_zoneinfo

Refleaks on all other platforms, including s390x, are clean. At the moment we're treating this as unrelated and we'll be looking at a solution to those failures separately.

Reviewers

@picnixz picnixz picnixz left review comments

@1st1 1st1 Awaiting requested review from 1st1

@ambv ambv Awaiting requested review from ambv

@asvetlov asvetlov Awaiting requested review from asvetlov

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

@willingc willingc Awaiting requested review from willingc

Labels