◐ Shell
clean mode source ↗

gh-129223: Raise KeyError in search_map_for_section() if not found by vstinner · Pull Request #129262 · python/cpython

Merged

ambv

merged 2 commits into

Jan 25, 2025

Conversation

@vstinner

@ambv

I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in #129225 actually addresses the problem, which was the compiler optimizing away debug sections unless __attribute__((used)) was used.

@vstinner

I can modify my PR to not skip the tests on KeyError.

@pablogsal

I can modify my PR to not skip the tests on KeyError.

This should be fixed by the real fix #129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍

@vstinner

@ambv @pablogsal: Ok, I modified my PR only to fix the SystemError, tests are no longer skipped.

@vstinner vstinner deleted the search_map_for_section branch

January 25, 2025 20:12

Labels