GH-128563: Simplify recursion check in `_PyEval_EvalFrameDefault` by markshannon · Pull Request #129481 · python/cpython
Conversation
|
|
||
|
|
||
| if (_Py_EnterRecursiveCallTstate(tstate, "")) { | ||
| assert(frame->owner != FRAME_OWNED_BY_INTERPRETER); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need to _Py_LeaveRecursiveCallPy after this as well?
At least from reading the code of exit_unwind.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. We haven't called _Py_EnterRecursivePy
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
I have made the requested changes; please review again
Thanks for making the requested changes!
@Fidget-Spinner: please review the changes made to this pull request.
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request
Labels
2 participants
