◐ Shell
clean mode source ↗

gh-111178: fix UBSan failures in `Modules/itertoolsmodule.c` by picnixz · Pull Request #129780 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@picnixz

@picnixz picnixz commented

Feb 7, 2025

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

@picnixz picnixz changed the title gh-111178: fix UBSan failures in Modules/_itertoolsmodule.c gh-111178: fix UBSan failures in Modules/itertoolsmodule.c

Feb 7, 2025

@picnixz picnixz marked this pull request as ready for review

February 8, 2025 09:39

@picnixz picnixz requested a review from rhettinger as a code owner

February 8, 2025 09:39

@encukou encukou merged commit f8c041b into python:main

Feb 19, 2025

@picnixz picnixz deleted the fix/ubsan/itertools-111178 branch

February 21, 2025 12:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @encukou