gh-111178: fix UBSan failures in `Modules/_lzmamodule.c` by picnixz · Pull Request #129783 · python/cpython
Conversation
Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)) so I'll fix them tomorrow.
| } | ||
| PyTypeObject *tp = Py_TYPE(self); | ||
| tp->tp_free((PyObject *)self); | ||
| tp->tp_free(self); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be op?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tp_free takes a void * as input, so it doesn't matter. I've chosen the one that reduces the diff (but honestly, I don't know whether I've always been consistent)
Labels
2 participants
