◐ Shell
clean mode source ↗

gh-111178: fix UBSan failures in `Modules/_operator.c` by picnixz · Pull Request #129785 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented

Feb 7, 2025

edited by bedevere-app Bot

Loading

@picnixz picnixz marked this pull request as ready for review

February 7, 2025 18:19

picnixz

picnixz

Semantically, this helps differencing a NOARGS from a VARARGS method without looking at the flags.

@picnixz

Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)). Even though _ + lowercase letter is not UB (hopefully), this one can be reviewed. However, for consistency, I'll also remove the _ tomorrow along with the other PRs.

@picnixz picnixz deleted the fix/ubsan/operator-111178 branch

February 21, 2025 12:35

Labels

2 participants

@picnixz @encukou