◐ Shell
clean mode source ↗

gh-111178: fix UBSan failures in `Modules/_randommodule.c` by picnixz · Pull Request #129791 · python/cpython

picnixz

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@picnixz

@picnixz picnixz commented

Feb 7, 2025

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.

@picnixz

picnixz commented

Feb 7, 2025

Copy link Copy Markdown

Member Author

Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)) so I'll fix them tomorrow.

@picnixz picnixz marked this pull request as draft

February 7, 2025 18:37

@picnixz picnixz marked this pull request as ready for review

February 8, 2025 09:28

@encukou encukou enabled auto-merge (squash)

February 21, 2025 14:37

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit 2922429 into python:main

Feb 21, 2025

@picnixz picnixz deleted the fix/ubsan/random-111178 branch

February 21, 2025 15:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz @vstinner @encukou