gh-111178: fix UBSan failures in `Modules/_tkinter.c` by picnixz · Pull Request #129795 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Merged
Conversation
Member
This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.
picnixz added 4 commits
picnixz added 2 commits
encukou
reviewed
picnixz
commented
Feb 25, 2025
picnixz commented
Member Author
Independently of this PR, but can't we actually transform static types of tkinter into heap types?
encukou
approved these changes
encukou
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One nitpick left:
Modules/_tkinter.c Outdated
encukou
commented
Feb 25, 2025
encukou commented
Member
Independently of this PR, but can't we actually transform static types of tkinter into heap types?
See #103092 (comment) & #103108
59d3ad0
into
python:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
