◐ Shell
clean mode source ↗

gh-130931: Add PyFrame_SetBack() function by vstinner · Pull Request #131252 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@vstinner

@vstinner vstinner commented

Mar 14, 2025

edited by github-actions Bot

Loading

Copy link Copy Markdown

Member

Add tests on PyFrame_GetBack() and PyFrame_SetBack().


📚 Documentation preview 📚: https://cpython-previews--131252.org.readthedocs.build/

Add tests on PyFrame_GetBack() and PyFrame_SetBack().

@vstinner

Copy link Copy Markdown

Member Author

The coroutine support then needs to inject frames into the current stack. For this, we currently read and write f_back:
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L784-L831
https://github.com/cython/cython/blob/f193ba860b94a7139cffd8b0d11b7ef977aa10d3/Cython/Utility/Coroutine.c#L870-L897

@da-woods: Would this function PyFrame_SetBack() be useful to Cython?

@vstinner

Copy link Copy Markdown

Member Author

@da-woods

Copy link Copy Markdown

Contributor

It'd work for us for our coroutine usage, but from what Mark said, it sounds like there might be issues exposing it more generally.

@vstinner

vstinner commented

Mar 20, 2025

edited

Loading

Copy link Copy Markdown

Member Author

@markshannon is against this API: #130931 (comment). So I prefer to close my PR.

@vstinner vstinner closed this

Mar 20, 2025

@vstinner vstinner deleted the frame_setback branch

March 20, 2025 11:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @da-woods