◐ Shell
clean mode source ↗

gh-111178: Fix function signature for test_threading by vstinner · Pull Request #131663 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented

Mar 24, 2025

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

@picnixz picnixz left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the explicit cast to _Py_once_fn_t:

    _PyOnceFlag_CallOnce(&self->once, (_Py_once_fn_t *)force_done, self);
vstinner reacted with thumbs up emoji

@vstinner vstinner enabled auto-merge (squash)

March 24, 2025 13:32

@vstinner vstinner merged commit 78f1bac into python:main

Mar 24, 2025

@vstinner vstinner deleted the ubsan_test_threading branch

March 24, 2025 13:56

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 1, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @picnixz