◐ Shell
clean mode source ↗

gh-128813: hide mixed-mode functions for complex arithmetic from C-API by skirpichev · Pull Request #131703 · python/cpython

skirpichev

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@skirpichev

@skirpichev skirpichev commented

Mar 25, 2025

•

edited by github-actions Bot

Loading

Copy link Copy Markdown

Member

@skirpichev

Copy link Copy Markdown

Member Author

@skirpichev skirpichev requested review from a team and erlend-aasland as code owners

March 25, 2025 08:40

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev

skirpichev commented

Apr 15, 2025

•

edited

Loading

Copy link Copy Markdown

Member Author

CC @serhiy-storchaka

I doubt C-API WG issue will be solved til 3.14 beta1. So, lets remove added functions from the public API.

@skirpichev

Copy link Copy Markdown

Member Author

@vstinner

Copy link Copy Markdown

Member

Related discussion: capi-workgroup/decisions#56

@skirpichev

Copy link Copy Markdown

Member Author

I just worry, that it will be not finished til 3.14 beta. Or it's ok to revert this stuff after that?

@vstinner

Copy link Copy Markdown

Member

Ok, let's remove them for now. We can revisit this API later if we decide to expose it.

@skirpichev skirpichev deleted the remove-mixed-api/128813 branch

April 22, 2025 12:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skirpichev @vstinner