gh-91048: Chain some exceptions in _testexternalinspection.c by sergey-miryanov · Pull Request #132970 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 8 commits into
Conversation
Contributor
- Added extra Py_UNREACHABLE calls on unsupported platforms
- Remove unused refcnt read
- Set result to 0 if fd closing failed
- Chain some exceptions to get more info if failed
sergey-miryanov added 5 commits
Chain some exceptions in _testexternalinspection.c
gh-91048: Chain some exceptions in _testexternalinspection.c
picnixz
reviewed
Modules/_testexternalinspection.c Outdated
sergey-miryanov added 3 commits
- I believe it is not worth to add conditional compilation of such small function like chain_exceptions
sergey-miryanov
commented
Apr 25, 2025
sergey-miryanov commented
Contributor Author
@pablogsal Please take a look.
pablogsal
approved these changes
pablogsal
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a great improvement. Thanks a lot!
pablogsal
approved these changes
bd2ed7c
into
python:main
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
