◐ Shell
clean mode source ↗

gh-87135: test_threading: Wait on thread, not an Event it sets by encukou · Pull Request #133198 · python/cpython

encukou

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@encukou

@encukou encukou commented

Apr 30, 2025

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

Sorry for this mistake!
When the event is set the thread might not be done yet. This should fix newly-flaky refleak buildbots.

This is a fix-up for commit 4ebbfcf

 
When the event is set the thread might not be done yet.

This is a fix-up for commit 4ebbfcf

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
encukou reacted with heart emoji

@encukou encukou merged commit 8b26b23 into python:main

Apr 30, 2025

@encukou encukou deleted the test_join_finished_daemon_thread_in_finalization branch

April 30, 2025 13:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @vstinner