GH-133231: Add JIT utilities in `sys._jit` by brandtbucher · Pull Request #133233 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick doc-only review:
Comment on lines +1284 to +1290
| .. envvar:: PYTHON_JIT | ||
|
|
||
| On builds where experimental just-in-time compilation is available, this | ||
| variable can force the JIT to be disabled (``0``) or enabled (``1``) at | ||
| interpreter startup. | ||
|
|
||
| .. versionadded:: 3.13 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should backport this, should it be split out into a different PR for ease?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just backport it separately, since I need the ref for this PR's changes.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth using miss-islington for the backport here?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just do it manually in a bit.
I just realized that my approach for sys._jit.is_active() will need reworking, since the tail-calling interpreter doesn't have entry_frame handy.
Okay, reworked to support tail-calling.
@markshannon, let me know what you think. The bots won't let us merge features without approving review, but I'd like to get something like this in before the freeze.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
One small suggestion
