Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport (GH-13098)" by vstinner · Pull Request #13329 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
asvetlov
approved these changes
vstinner
commented
May 14, 2019
vstinner commented
Member Author
I already reverted the change in 3.7: PR #13328.
The revert in master is motivated by https://bugs.python.org/issue36870 : test_asyncio fails randomly which causes a lot of pain in the Python CI and the Python workflow.
I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870
asvetlov
commented
May 14, 2019
asvetlov commented
Contributor
I don't know yet if PR #13313 fixed https://bugs.python.org/issue36870
I guess no, the PR #13313 doesn't fix your issue.
This pull request is necessary (but please don't revert #13313 and #13099)
asvetlov
commented
May 14, 2019
asvetlov commented
Contributor
#13330 is a minimal change that reverts StreamWriter.drain() on the master to code that was working properly.
I suggest to use it instead, tests should pass
vstinner
commented
May 14, 2019
vstinner commented
Member Author
I suggest to use it instead, tests should pass
Honestly, I don't care: it's up to you, as soon as test_asyncio pass: as soon as https://bugs.python.org/issue36870 is fixed.
vstinner
commented
May 14, 2019
vstinner commented
Member Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
