◐ Shell
clean mode source ↗

gh-131178: Add tests for `ast` command-line interface by donbarbos · Pull Request #133329 · python/cpython

Conversation

StanFromIreland

tomasr8

Eclips4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

sobolevn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also test that -h and --help works.

sobolevn

JelleZijlstra

sobolevn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor things :)

Co-authored-by: sobolevn <mail@sobolevn.me>

sobolevn

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@donbarbos

diegorusso added a commit to diegorusso/cpython that referenced this pull request

May 4, 2025

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025
…33329)

Co-authored-by: sobolevn <mail@sobolevn.me>

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@tomasr8 tomasr8 tomasr8 left review comments

@Eclips4 Eclips4 Eclips4 approved these changes

@StanFromIreland StanFromIreland StanFromIreland left review comments

@sobolevn sobolevn sobolevn approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Labels