GH-91048: Minor fixes for ``_remotedebugging`` & rename to ``_remote_debugging`` by AA-Turner · Pull Request #133398 · python/cpython
Btw, would you support adding an underscore to the module name? I keep reading it as 'remoted ...', and
_remote_debuggingwould better match the C files.
Yep, if you want, go ahead and make the changes
| PY_STDLIB_MOD([readline], | ||
| [], [test "$with_readline" != "no"], | ||
| [$READLINE_CFLAGS], [$READLINE_LIBS]) | ||
| PY_STDLIB_MOD([_remotedebugging], [test "$TEST_MODULES" = yes]) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablogsal should we keep this "$TEST_MODULES" = yes condition? It's inherited from before the rename, but I don't know what conditions you want the module to be enabled under.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop, that was from before when this was a test module. Let's remove it
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've pushed a fix for this & also the rename to _remote_debugging. Thanks!
GH-91048: Minor fixes after renaming to _remotedebugging
GH-91048: Minor fixes for _remotedebugging & rename to _remote_debugging
# Conflicts: # PCbuild/pcbuild.sln
Hummmm, seems that this collided with the other PR, could you rebase? I can land it afterwards.
If you don't have time I can rebase myself if you prefer :)
# Conflicts: # Lib/test/test_external_inspection.py
Thanks! resolved conflicts
A
zanieb added a commit to astral-sh/python-build-standalone that referenced this pull request
