gh-82129: Improve annotations for make_dataclass() by JelleZijlstra · Pull Request #133406 · python/cpython
Conversation
…wt3u.rst Co-authored-by: Carl Meyer <carl@oddbird.net>
| try: | ||
| ann = _get_dunder_annotations(obj) | ||
| except NameError: | ||
| except Exception: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a separate PR (with tests) for this change in #133407.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviving this PR! It looks like it achieves its main goal.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request
Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Carl Meyer <carl@oddbird.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 participants
