◐ Shell
clean mode source ↗

bpo-36876: Use a consistent variable name for kwlist. by ericsnowcurrently · Pull Request #13531 · python/cpython

ericsnowcurrently

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented

May 23, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Having a consistent variable name helps simplify efforts to identify C globals that need to be moved. (A consistent name is easier to ignore.)

https://bugs.python.org/issue36876

@vstinner

Copy link Copy Markdown

Member

I'm not super excited by PR only changing the coding style. Can't you use a tool which understand that the static is a constant and it's value is constant?

@ericsnowcurrently

Copy link Copy Markdown

Member Author

You're right. :)

@vstinner

Copy link Copy Markdown

Member

Sorry :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ericsnowcurrently @vstinner @the-knights-who-say-ni @bedevere-bot