bpo-37094: Add example for TestCase.skipTest in unittest doc by MakDon · Pull Request #13645 · python/cpython
Hi @csabella , according to Python Developer’s Guide, Trivial issues (e.g. typo fixes) do not require any issue to be created.
It's just a document updating, so maybe it is not important enough to create an issue on issues tracker.
Thank you for your reply! :D
Yes, it's not obvious what trivial means, but it's really just a pull request with only a few typo fixes. Adding an additional example is more than trivial. Also, some core devs primary way of discovering issues is through the bug tracker, so adding a PR without a bug tracker link increases that likelihood of a change not being reviewed. It's usually better to have a bpo number than to not have one. 🙂
Add example for TestCase.skipTest in unittest doc
bpo-37094: Add example for TestCase.skipTest in unittest doc
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a little bit of cleanup, but I think this will end up as a nice improvement!
| # windows specific testing code | ||
| pass | ||
|
|
||
| def test_skip_me(self): |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you take my second suggestion for the body of this example method, it could use a better name ("test_maybe_skipped" or similar, perhaps).
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Co-Authored-By: Zachary Ware <zachary.ware@gmail.com>
@zware Thanks for your suggestions.
The document is still WIP.Please wait for a minute.
Thank your again!
Update unittest according @zware's suggestions.
I have made the requested changes; please review again.
Thanks for making the requested changes!
@zware: please review the changes made to this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is no restriction on documentation improvements; this will apply to 3.7 and beyond :)
Thanks @MakDon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
