◐ Shell
clean mode source ↗

[3.7] bpo-31829: Make protocol 0 pickles be loadable in text mode in Python 2. (GH-11859) by miss-islington · Pull Request #13693 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

May 31, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Escape \r, \0 and \x1a (end-of-file on Windows) in Unicode strings.
(cherry picked from commit 38ab7d4)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

https://bugs.python.org/issue31829

 
… 2. (pythonGH-11859)

Escape ``\r``, ``\0`` and ``\x1a`` (end-of-file on Windows) in Unicode strings.
(cherry picked from commit 38ab7d4)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

Copy link Copy Markdown

Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

@vstinner

Copy link Copy Markdown

Member

@serhiy-storchaka: can this change be merged into 3.7? It LGTM.

@miss-islington miss-islington merged commit d561f84 into python:3.7

Jun 12, 2019

@miss-islington miss-islington deleted the backport-38ab7d4-3.7 branch

June 12, 2019 11:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @vstinner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot