◐ Shell
clean mode source ↗

[3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… by JelleZijlstra · Pull Request #137013 · python/cpython

JelleZijlstra

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented

Jul 22, 2025

•

edited by bedevere-app Bot

Loading

Copy link Copy Markdown

Member

… a dataclass, make the original class collectible (GH-136893) (#136960)"

This reverts commit 6e1b31b.

Modifying the __dict__ is likely to cause crashes

 
…places a dataclass, make the original class collectible (pythonGH-136893) (python#136960)"

This reverts commit 6e1b31b.

Modifying the `__dict__` is likely to cause crashes

@hugovk hugovk left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's revert this for RC1 and we'll consider another approach for RC2.

@hugovk hugovk enabled auto-merge (squash)

July 22, 2025 16:11

@hugovk hugovk merged commit 70990ed into python:3.14

Jul 22, 2025

48 checks passed

kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request

Sep 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

@hugovk hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra @hugovk