bpo-36842: Pass positional only parameters to code_new audit hook by pablogsal · Pull Request #13707 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Member
pablogsal
added
the
skip news
label
pablogsal
requested a review
from zooba
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting core review
label
pablogsal
requested a review
from tiran
zooba
approved these changes
zooba
left a comment
zooba
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, though only because we haven't shipped this event before. In future we'd have to create a new event name and raise both here.
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
pablogsal
force-pushed
the
code_type_audit
branch
from
170c3ab to
fa68f36
Compare
pablogsal
commented
May 31, 2019
pablogsal commented
Member Author
Thanks @zooba for the review!
pablogsal
merged commit
3b57f50
into
python:master
bedevere-bot
removed
the
awaiting merge
label
pablogsal
deleted the
code_type_audit
branch
DinoV pushed a commit to DinoV/cpython that referenced this pull request
zooba
mentioned this pull request
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment