◐ Shell
clean mode source ↗

bpo-37151: remove _PyFunction_FastCallDict by jdemeyer · Pull Request #13864 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jdemeyer

@jdemeyer jdemeyer commented

Jun 6, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Now that function objects use vectorcall, _PyFunction_FastCallDict is dead code so we might as well remove it.

https://bugs.python.org/issue37151

@jdemeyer jdemeyer marked this pull request as ready for review

June 6, 2019 13:27

@methane methane merged commit 5954334 into python:master

Jun 18, 2019

@jdemeyer jdemeyer deleted the remove_PyFunction_FastCallDict branch

June 18, 2019 11:10

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mangrisano mangrisano mangrisano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdemeyer @mangrisano @methane @the-knights-who-say-ni @bedevere-bot