gh-135755: Make Py_TAIL_CALL_INTERP macro private by vstinner · Pull Request #138981 · python/cpython
Conversation
@Fidget-Spinner: I blindly replaced Py_TAIL_CALL_INTERP text with _Py_TAIL_CALL_INTERP. I didn't test my change.
I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.
I built Python with tail call on Linux using
./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that./python -m test test_sys -vstill pass.
Don't worry, we have CI for the tail calling interpreter on most platforms, so you can just let it run :)
@hugovk: This change mostly/only makes sense if it's backported to 3.14. Would you accept this late C API change in 3.14? It makes the macro private.
Maybe it's ok to leave the macro in 3.14 and remove it in 3.15. No one should rely on this macro :-)
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6504f20ccedf0b27275327e72698dee5f0c75ba8 3.14
vstinner added a commit to vstinner/cpython that referenced this pull request
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP. (cherry picked from commit 6504f20)
@Fidget-Spinner suggested me to merge this change in the main branch, so I did it :-)