gh-139003: Use frozenset for module level attributes in _pyrepl.utils by eendebakpt · Pull Request #139004 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Contributor
Improve performance by using a frozenset instead of a set for module level attributes. Identified in #138931 (comment).
eendebakpt
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
bedevere-app
Bot
added
the
awaiting review
label
bedevere-app
Bot
mentioned this pull request
StanFromIreland
added
the
skip news
label
efimov-mikhail
approved these changes
efimov-mikhail
left a comment
efimov-mikhail
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bedevere-app
Bot
added
awaiting core review
and removed
awaiting review
labels
bedevere-app
Bot
removed
the
awaiting core review
label
maurycy added a commit to maurycy/cpython that referenced this pull request
…ktor * upstream/main: (119 commits) pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845) pythongh-146558: JIT optimize dict access for objects with known hash (python#146559) pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570) pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631) pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593) pythongh-138122: Add differential flame graph (python#145785) pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417) pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628) pythongh-138850: Add --disable-epoll to configure (pythonGH-145768) pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624) pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597) pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557) pythongh-146579: _zstd: Fix decompression options dict error message (python#146577) pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085) pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573) pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569) pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472) pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580) pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004) pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532) ...
pablogsal
mentioned this pull request
clin1234 pushed a commit to clin1234/cpython that referenced this pull request
….utils (python#139004) Use frozenset for module level attributes
ljfp pushed a commit to ljfp/cpython that referenced this pull request
….utils (python#139004) Use frozenset for module level attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment