◐ Shell
clean mode source ↗

bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors by vstinner · Pull Request #13955 · python/cpython

vstinner

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Closed

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:test_urllib_del

Closed

bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors#13955

vstinner

wants to merge 1 commit into

python:masterfrom

vstinner:test_urllib_del

Conversation

@vstinner

@vstinner vstinner commented

Jun 11, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Implement FakeHTTPConnection.close() to silence destructor errors.

Co-Authored-By: Xtreak tir.karthi@gmail.com

https://bugs.python.org/issue36918

 
Implement FakeHTTPConnection.close() to silence destructor errors.

Co-Authored-By: Xtreak <tir.karthi@gmail.com>

@vstinner

Copy link Copy Markdown

Member Author

Oh. It was too easy: test_urllib2 fails with my change :-(

@tirkarthi

Copy link Copy Markdown

Member

Yes, this was my first approach as well but test_urllib2 explicitly checks Fakesocket is closed.

@vstinner

Copy link Copy Markdown

Member Author

This PR is wrong. I wrote PR #13996 which is correct.

@vstinner vstinner closed this

Jun 12, 2019

@vstinner vstinner deleted the test_urllib_del branch

June 12, 2019 01:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @tirkarthi @the-knights-who-say-ni @bedevere-bot