◐ Shell
clean mode source ↗

[3.8] bpo-26219: Fix compiler warning in _PyCode_InitOpcache() (GH-13997) by miss-islington · Pull Request #14000 · python/cpython

the-knights-who-say-ni

Conversation

@miss-islington

@miss-islington miss-islington commented

Jun 12, 2019

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fix MSVC warning:

objects\codeobject.c(285): warning C4244: '=':
conversion from 'Py_ssize_t' to 'unsigned char',
possible loss of data

(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue26219

 
)

Fix MSVC warning:

    objects\codeobject.c(285): warning C4244: '=':
    conversion from 'Py_ssize_t' to 'unsigned char',
    possible loss of data
(cherry picked from commit 376ce98)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner vstinner merged commit 996e526 into python:3.8

Jun 12, 2019

@miss-islington miss-islington deleted the backport-376ce98-3.8 branch

June 12, 2019 10:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot