gh-140873: Add support of non-descriptor callables in functools.singledispatchmethod() by serhiy-storchaka · Pull Request #140884 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also add a regression test where singledispatchmethod decorates a descriptor method but a non-descriptor callable is registered like in the original issues? Just to make sure that never regresses.
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request
