◐ Shell
clean mode source ↗

bpo-37289: Remove 'if False' handling in the peephole optimizer by pablogsal · Pull Request #14099 · python/cpython

pablogsal

Conversation

@pablogsal pablogsal changed the title Remove 'if False' handling in the peephole optimizer bpo-37289; Remove 'if False' handling in the peephole optimizer

Jun 15, 2019

@pablogsal pablogsal changed the title bpo-37289; Remove 'if False' handling in the peephole optimizer bpo-37289: Remove 'if False' handling in the peephole optimizer

Jun 15, 2019

serhiy-storchaka

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if PyObject_IsTrue() returns -1?

@pablogsal

@serhiy-storchaka It goes to the break and skips to the next bytecode, right? I am missing something?

@serhiy-storchaka

It should be handled as an error.

@pablogsal

serhiy-storchaka

@miss-islington

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 15, 2019 
…onGH-14099)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

@miss-islington

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

pablogsal added a commit that referenced this pull request

Jun 15, 2019 
…4099) (GH-14112)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

pablogsal added a commit that referenced this pull request

Jun 15, 2019 
…4099) (GH-14111)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

Labels