gh-136702: Clear codec caches for refleak tests; use test.support helpers by encukou · Pull Request #141345 · python/cpython
Conversation
| "Support for non-ascii encoding names will be removed in 3.17"): | ||
| msg = "Support for non-ascii encoding names will be removed in 3.17" | ||
| with warnings_helper.check_warnings((msg, DeprecationWarning)): | ||
| self.assertEqual(normalize('utf\xE9\u20AC\U0010ffff-8'), 'utf_8') |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to bump the 3.17 to 3.20 if we want to have a 5 year deprecation phase.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's up for discussion in the issue; here I'm only unbreaking the buildbots.
encukou
deleted the
clear-codec-caches-in-regrtest
branch
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters