◐ Shell
clean mode source ↗

bpo-37328: remove deprecated HTMLParser.unescape by methane · Pull Request #14186 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

methane

merged 2 commits into

Aug 27, 2019

Conversation

It is deprecated since Python 3.4

@methane

@methane

pypa/setuptools#1788 is fixed.
I wait new setuptools is released and bundled setuptools is upgraded to >=41.0.2

ezio-melotti

import warnings
import _markupbase

from html import unescape

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be removed too if it's no longer needed (even though removing it might break some code if people are doing from html.parser import unescape instead of from html import unescape).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unescape is used in this module several times.

@pradyunsg

#15483 bumps the setuptools version, so that'll unblock this once merged.

@methane methane deleted the remove-deprecated-unescape branch

August 27, 2019 02:48

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019
It is deprecated since Python 3.4.

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020
It is deprecated since Python 3.4.

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request

Jul 20, 2020
It is deprecated since Python 3.4.

Labels

type-bug

An unexpected behavior, bug, or error