◐ Shell
clean mode source ↗

gh-142543: Mark tracer functions as Py_NO_INLINE by Fidget-Spinner · Pull Request #142846 · python/cpython

Fidget-Spinner

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented

Dec 16, 2025

•

edited

Loading

Copy link Copy Markdown

Member

@Fidget-Spinner Fidget-Spinner changed the title gh-142543: Mark tracer function as Py_NO_INLINE gh-142543: Mark tracer functions as Py_NO_INLINE

Dec 16, 2025

@Fidget-Spinner

Copy link Copy Markdown

Member Author

This is basically the same as #137731

@savannahostrowski savannahostrowski left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fidget-Spinner

Copy link Copy Markdown

Member Author

I'd like to get this in ASAP as this breaks JIT builds on all clang-based systems without tailcalling and with LTO on.

@Fidget-Spinner Fidget-Spinner merged commit 89729f2 into python:main

Dec 17, 2025

64 checks passed

@Fidget-Spinner Fidget-Spinner deleted the no_inilne_tracer branch

December 17, 2025 00:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SIGSEGV in test_isinstance and test_json with --enable-experimental-jit=yes and --with-lto=full

2 participants

@Fidget-Spinner @savannahostrowski