◐ Shell
clean mode source ↗

[3.8] bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416) by miss-islington · Pull Request #14417 · python/cpython

Skip to content

Navigation Menu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

  • Fix typo in supports_file2file_sendfile(); ensure that dst is
    removed
  • Fix test_copytree_custom_copy_function(): remove dst tree.
    Use support.rmtree() rather than shutil.rmtree() to remove
    temporary directories: support tries harder.
    (cherry picked from commit 4c26abd)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37421

* Fix typo in supports_file2file_sendfile(); ensure that dst is
  removed
* Fix test_copytree_custom_copy_function(): remove dst tree.
  Use support.rmtree() rather than shutil.rmtree() to remove
  temporary directories: support tries harder.
(cherry picked from commit 4c26abd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment

@miss-islington

@vstinner: Status check is done, and it's a success ✅ .

Labels

tests

Tests in the Lib/test dir