◐ Shell clean mode source ↗

[3.8] bpo-37421: test_winconsoleio doesn't leak temp file anymore (GH-14562) by miss-islington · Pull Request #14569 · python/cpython

bedevere-bot

Skip to content

Merged

merged 1 commit into

miss-islington:backport-b71d8d6-3.8

Jul 3, 2019

Merged

[3.8] bpo-37421: test_winconsoleio doesn't leak temp file anymore (GH-14562)#14569
miss-islington
merged 1 commit into
python:3.8from
miss-islington:backport-b71d8d6-3.8

Conversation

miss-islington commented
Jul 3, 2019
•

edited by bedevere-bot

Loading

Copy link

Copy Markdown

Contributor

test_winconsoleio doesn't leak a temporary file anymore: use
tempfile.TemporaryFile() to remove it when the test completes.
(cherry picked from commit b71d8d6)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37421

bpo-37421: test_winconsoleio doesn't leak temp file anymore (pythonGH…

…-14562)

test_winconsoleio doesn't leak a temporary file anymore: use
tempfile.TemporaryFile() to remove it when the test completes.
(cherry picked from commit b71d8d6)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

bedevere-bot mentioned this pull request

bpo-37421: test_winconsoleio doesn't leak temp file anymore #14562

Merged

the-knights-who-say-ni added the CLA signed label

bedevere-bot added tests

awaiting review labels

vstinner approved these changes Jul 3, 2019

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

bedevere-bot added awaiting merge and removed awaiting review labels

miss-islington commented
Jul 3, 2019

Copy link

Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

miss-islington merged commit a2a807f into python:3.8

bedevere-bot removed the awaiting merge label

miss-islington deleted the backport-b71d8d6-3.8 branch

July 3, 2019 09:31

miss-islington commented
Jul 3, 2019

Copy link

Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented
Jul 3, 2019

Copy link

Copy Markdown

Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants