bpo-37504: Fix documentation build with texinfo builder by mitya57 · Pull Request #14606 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mitya57 Thanks for the contribution! In order to fully verify that the change is working appropriately since this is addressing a specific bug (Documentation fails to build when using Sphinx' textinfo builder), I would advise advise updating the tests (which would be included in the PR). A screenshot does provide a solid visual example, but is usually not reliable enough to show that it fully functions as described in the initial issue. This also helps to ensure that if your addition works as intended, no other changes will unintentionally break it.
The above suggestions might not be necessary in order for your PR to be merged, but in general adding tests is always helpful, especially when it involves a change in functionality or fixing a bug that was under the radar of the existing tests.