◐ Shell
clean mode source ↗

gh-146175: Soft-deprecate outdated macros; convert internal usage by encukou · Pull Request #146178 · python/cpython

Conversation

@encukou

@encukou encukou commented

Mar 19, 2026

edited by github-actions Bot

Loading

vstinner

Py_BUILD_ASSERT(sizeof(wchar_t) >= 4);
#else
Py_BUILD_ASSERT(sizeof(wchar_t) < 4);
#endif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move these checks into a sub-function called by _testcapi_exec()?

@encukou encukou marked this pull request as ready for review

March 20, 2026 15:36

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Victor Stinner <vstinner@python.org>

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Mar 23, 2026

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026

2 participants

@encukou @vstinner