gh-146205: Check the errno with != 0 in close impls in select module by aisk · Pull Request #146206 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR merged, thanks for the fix.
I'm not sure about backporting this change to 3.13 and 3.14. This change can cause applications to start failing since errors were ignored silently previously. I prefer to only introduce the change in Python 3.15.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request
ljfp pushed a commit to ljfp/cpython that referenced this pull request
…odule (python#146206) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters