gh-146245: Fix reference and buffer leaks via audit hook in socket module by aisk · Pull Request #146248 · python/cpython

aisk

Conversation

aisk changed the title ~~gh-146245: Fix reference and buffer leaks audit hook in socket module~~ gh-146245: Fix reference and buffer leaks via audit hook in socket module

Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

The tests are reverted.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Thanks @aisk for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 22, 2026

…ket module (pythonGH-146248)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 22, 2026

…ket module (pythonGH-146248)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

Mar 23, 2026

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026

gh-146245: Fix reference and buffer leaks via audit hook in socket module by aisk · Pull Request #146248 · python/cpython

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

2 participants