gh-146261: JIT: protect against function version changes by Fidget-Spinner · Pull Request #146300 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
merged 7 commits into
Conversation
Member
This PR reverts the func_version symbol changes by using the fact that we have recorded values and _CHECK_FUNCTION_VERSION guards --- if we simply keep those around and not eliminate them, our function versions are guaranteed to be correct for all following _PUSH_FRAME if we invalidate dependencies properly in the function version changes.
Fidget-Spinner
requested review from
markshannon,
savannahostrowski and
tomasr8
as code owners
bedevere-app
Bot
mentioned this pull request
bedevere-app
Bot
added
the
awaiting core review
label
Fidget-Spinner
added
skip news
awaiting core review
and removed
awaiting core review
labels
Objects/funcobject.c Outdated
kumaraditya303
approved these changes
bedevere-app
Bot
added
awaiting merge
and removed
awaiting core review
labels
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sacul0457
mentioned this pull request
Fidget-Spinner
commented
Apr 9, 2026
Fidget-Spinner commented
Member Author
@markshannon does this bugfix look okay to you? The reason we need this is that __code__ can be swapped out for functions. If you think it's okay, I can merge.
Fidget-Spinner added 4 commits
NekoAsakura
mentioned this pull request
bedevere-app
Bot
removed
the
awaiting merge
label
prakashsellathurai added a commit to prakashsellathurai/cpython that referenced this pull request
python#146300)" This reverts commit 6f7bb29.
ljfp pushed a commit to ljfp/cpython that referenced this pull request
…n#146300) Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment