gh-146388: Add null check for `sym_new(ctx)` in `make_bottom` by A0su · Pull Request #146389 · python/cpython
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
aisk
approved these changes
@aisk, blurb added. Thanks for the review!
| @@ -0,0 +1 @@ | |||
| Add a null check for :func:`sym_new(ctx)` in :func:`make_bottom` | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't tell much. Can it be more descriptive please? Something like
Handle when JIT optimizer runs out of space when dealing with contradictions.
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'm not sure that the NEWS entry is worth it, it's a corner case which is unlikely to occur in practice, no?
