[3.13] gh-146615: Fix format specifiers in Objects/ directory (GH-146620) by sunmy2019 · Pull Request #147705 · python/cpython
Conversation
I found a new error specific to 3.13.
| if (the_current_tok->f_string_quote == quote && | |
| the_current_tok->f_string_quote_size == quote_size) { | |
| return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start)); | |
| } |
- return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start)); + return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'"));
This is fixed by 6020260 in 3.14.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. i is declared as an int.
Hum. Your PR description described a bug which is not fixed by the PR. It's misleading.
Do you plan to integrate a fix for return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start)); in this PR?
Do you plan to integrate a fix for
return MAKE_TOKEN(_PyTokenizer_syntaxerror(tok, "f-string: expecting '}'", start));in this PR?
I’m not sure if I should fix it within this PR or address it in a separate one. What do you think?
You can update this PR to fix also the _PyTokenizer_syntaxerror() issue.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged, thanks for fixes.
Labels
2 participants
