gh-149017: Upgrade bundled Expat to 2.8.0 by StanFromIreland · Pull Request #149020 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we actually are using a poor entropy source and later we will use the entropy source defined by Expat? The BPO issue seems also unsure on whether we wanted this for the C accelerated module. If we still want a poor entropy, I wonder why we need to undef those HAVE_* constants.
Because we would hit (in xmlparse.c):
#if ! defined(HAVE_ARC4RANDOM_BUF) && ! defined(HAVE_ARC4RANDOM)
on Windows I think? I'm confused here about (1) why we want poor entropy (2) why we undef those macros.