◐ Shell
clean mode source ↗

bpo-37268: Add deprecation notice and a DeprecationWarning for the parser module by pablogsal · Pull Request #15017 · python/cpython

Conversation

@pablogsal

Let's deprecate this once and for all! ⚔️

pablogsal


if (PyErr_WarnEx(PyExc_DeprecationWarning,
"The parser module is deprecated and will be removed "
"in future versions of Python", 7) != 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 is the magic number to skip all importlib._bootstrap_external (tested in test_deprecation_message). 🙃

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablogsal

vstinner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request

Jul 20, 2020